Skip to content

Conversation

@dikshita-agarwal
Copy link
Contributor

No description provided.

@Manigurr Manigurr force-pushed the testingbranch branch 6 times, most recently from d8c6e36 to d65c91e Compare January 9, 2026 09:20
@Manigurr Manigurr force-pushed the video.upstream(stage) branch from 427069d to c442ba0 Compare January 9, 2026 10:05
On SM8250 (IRIS2) with firmware older than 1.0.087, the firmware
could not handle a dummy device address for EOS buffers, so a NULL
device address is sent instead. The existing check used IS_V6()
with a firmware version gate:

    if (IS_V6(core) && is_fw_rev_or_older(core, 1, 0, 87))
        fdata.device_addr = 0;
    else
        fdata.device_addr = 0xdeadb000;

However, SC7280, which is also V6, uses a firmware string of the
form "1.0.<commit-hash>". The version parser translates this to
1.0.0. This satisfies the is_fw_rev_or_older(..., 1, 0, 87)
condition on SC7280. Combined with IS_V6() matching, the quirk is
incorrectly applied there and causes VP9 decode failures.

Constrain the check to IRIS2 (SM8250) only, which is the only
platform that needs this quirk, by replacing IS_V6() with
IS_IRIS2(). This restores correct behavior on SC7280 and avoids a
forced NULL EOS buffer address.

Fixes: 47f867c ("media: venus: fix EOS handling in decoder stop")
Cc: stable@vger.kernel.org
Reported-by: Mecid <mecid@mecomediagroup.de>
Closes: qualcomm-linux#222
Co-developed-by: Renjiang Han <renjiang.han@oss.qualcomm.com>

Signed-off-by: Renjiang Han <renjiang.han@oss.qualcomm.com>
Signed-off-by: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants